Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4693/transaction receipt effective gas price 4.x #4866

Merged
merged 5 commits into from
Mar 22, 2022
Merged

4693/transaction receipt effective gas price 4.x #4866

merged 5 commits into from
Mar 22, 2022

Conversation

nikoulai
Copy link
Contributor

@nikoulai nikoulai commented Mar 17, 2022 •
edited
Loading

Description

#4693

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Mar 17, 2022

Your Render PR Server URL is https://web3-js-pr-4866.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8po92r97ejbdv1j0bu0.

@nikoulai nikoulai changed the base branch from 1.x to 4.x March 17, 2022 19:00
@jdevcs
Copy link
Contributor

jdevcs commented Mar 21, 2022

Please also update branch and run tests,its out of date.

@jdevcs jdevcs added the 4.x 4.0 related label Mar 21, 2022
@nikoulai nikoulai merged commit ca59b6d into 4.x Mar 22, 2022
@nikoulai nikoulai deleted the 4693/transaction-receipt-effective-gas-price-4.x branch March 22, 2022 10:49
@snyk-bot snyk-bot mentioned this pull request Oct 16, 2022
Open
@adamlaska adamlaska mentioned this pull request Oct 16, 2022
Open
@Woodpile37 Woodpile37 mentioned this pull request Aug 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@avkos avkos avkos approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs jdevcs approved these changes

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees

@nikoulai nikoulai

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikoulai @jdevcs @nazarhussain @avkos @luu-alex